Repository navigation
CSSTUDIO-3811 Don't call Action.resolve() on the URL in the "Open Web Page Action" action - #3986
Open
abrahamwolk wants to merge 4 commits into
Open
abrahamwolk wants to merge 4 commits into
abrahamwolk wants to merge 4 commits into
Conversation
…Page Action Handler. Instead, expand macros, escape space characters, and open the resulting URL.
abrahamwolk
force-pushed
the
CSSTUDIO-3811
branch
from
October 26, 2026 13:59
1f9cf99 to
1352255
Compare
abrahamwolk
force-pushed
the
CSSTUDIO-3811
branch
from
October 26, 2026 14:08
2080d2e to
2cabc76
Compare
georgweiss
reviewed
Oct 27, 2026
| logger.log(Level.WARNING, "Open Web Page Action: URL has leading and/or trailing whitespace: \"{0}\"", url); | ||
| return; | ||
| } | ||
| else if (!(url.startsWith("http://") || url.startsWith("https://") || url.startsWith("file:"))) { |
Collaborator
There was a problem hiding this comment.
Maybe this check should be case insensitive, e.g. url.toLowerCase().startsWith...?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the implementation of the "Open Web Page" action in Phoebus to not call
ActionUtil.resolve()on the URL that it is given when the action is run, and instead to expand macros, escape space characters, and open the resulting URL.The motivation for this change is counterintuitive behavior observed when a URL is opened that Phoebus fails to open. I think that the core reason for the counterintuitive behavior is that the concept in Phoebus of "resolving a resource" is a Phoebus-internal concept: a resource (e.g., of the form
examples:/...) may resolve internally in Phoebus, but not resolve outside of the Phoebus process. The converse can also be true: an external application (such as a web browser) may be able to resolve a resource that Phoebus cannot resolve.As a consequence of the change implemented in this pull request, Phoebus no longer checks whether it can open a URL before opening the URL in the web browser. (I believe that this is correct, based on the reasoning in the previous paragraph.)