Skip to content

Alarm tree search - #3988

Draft
LordIdra wants to merge 6 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-search
Draft

LordIdra wants to merge 6 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-search

Conversation

@LordIdra

@LordIdra LordIdra commented Oct 27, 2026 •

Copy link
Copy Markdown

Depends on #3987 - the diff is messed up until that is merged because I can't create a branch here for 3987 hence why this is a draft

Adds a search bar allowing you to search the alarm tree. This only lets you search by PV, not by component name, and does not include empty components.

2026-10-27.11-57-43.mp4

Implementation details: Annoyingly there isn't really a way to easily hide/show items in a tree that I could find, so this has to be done by adding/removing children. I added some methods to propagate visibility up the tree and adjusted the model update handling code to call them. For example, if a new alarm matching the current search is added to a hidden component, we want to show not only the alarm but also the component which was previously hidden.

The functionality added here which allows for nodes to be easily shown/hidden according to some criteria could have further uses, for example to only show active alarms

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • Tested changes by manually editing tree in a variety of ways, including with two clients open at once
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@georgweiss georgweiss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice feature, I'm sure my users will appreciate it.

Added comments on Java convention for variable naming, may have missed a few places.

@georgweiss

Copy link
Copy Markdown
Collaborator

I would maybe suggest a second button to clear the filter, this is easier than having to clear the text and then hit ENTER or Search.

@LordIdra

Copy link
Copy Markdown
Author

Thanks for the speedy review

@LordIdra
LordIdra requested a review from georgweiss October 27, 2026 14:46
@sonarqubecloud

Copy link
Copy Markdown

@LordIdra LordIdra mentioned this pull request Oct 28, 2026
12 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants