Repository navigation
Alarm tree search - #3988
Draft
LordIdra wants to merge 6 commits into
Draft
Alarm tree search#3988LordIdra wants to merge 6 commits into
LordIdra wants to merge 6 commits into
Conversation
LordIdra
force-pushed
the
alarm-tree-search
branch
from
October 27, 2026 12:07
259cb97 to
bee80eb
Compare
georgweiss
reviewed
Oct 27, 2026
georgweiss
reviewed
Oct 27, 2026
georgweiss
reviewed
Oct 27, 2026
georgweiss
reviewed
Oct 27, 2026
georgweiss
reviewed
Oct 27, 2026
georgweiss
left a comment
Collaborator
There was a problem hiding this comment.
Really nice feature, I'm sure my users will appreciate it.
Added comments on Java convention for variable naming, may have missed a few places.
Collaborator
|
I would maybe suggest a second button to clear the filter, this is easier than having to clear the text and then hit ENTER or Search. |
Author
|
Thanks for the speedy review |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Depends on #3987 - the diff is messed up until that is merged because I can't create a branch here for 3987 hence why this is a draft
Adds a search bar allowing you to search the alarm tree. This only lets you search by PV, not by component name, and does not include empty components.
2026-10-27.11-57-43.mp4
Implementation details: Annoyingly there isn't really a way to easily hide/show items in a tree that I could find, so this has to be done by adding/removing children. I added some methods to propagate visibility up the tree and adjusted the model update handling code to call them. For example, if a new alarm matching the current search is added to a hidden component, we want to show not only the alarm but also the component which was previously hidden.
The functionality added here which allows for nodes to be easily shown/hidden according to some criteria could have further uses, for example to only show active alarms
Checklist
Testing:
Documentation: