Repository navigation
Conversation
Add a new widget preference to an action button that allows users to change the corner radius. Also update the representation so that alarm borders follow the corner radius correctly.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We had a request from users to be able to configure whether the ActionButton had rounded corners or not. I believe by default in JavaFX there is some slight rounding to the corners and our users wanted to have no rounding (i.e. a true rectangle). This seemed to me like a nice thing to make configurable on the ActionButton and allow users to set the amount of rounding themselves (i.e. the corner radius).
Changes in this PR:
Checklist
Testing:
Documentation: