Skip to content

Allow ActionButton corner radius to be configurable - #3990

Open
rjwills28 wants to merge 2 commits into
ControlSystemStudio:masterfrom
rjwills28:action_button_corner_radii
Open

rjwills28 wants to merge 2 commits into
ControlSystemStudio:masterfrom
rjwills28:action_button_corner_radii

Conversation

@rjwills28

Copy link
Copy Markdown
Contributor

We had a request from users to be able to configure whether the ActionButton had rounded corners or not. I believe by default in JavaFX there is some slight rounding to the corners and our users wanted to have no rounding (i.e. a true rectangle). This seemed to me like a nice thing to make configurable on the ActionButton and allow users to set the amount of rounding themselves (i.e. the corner radius).

Changes in this PR:

  • Add a widget property to set the corner radius.
  • Default is left at 3, which reproduces the current behavior (i.e. slight rounding provided by JFX).
  • Alarm borders now follow the corner radius - previously they did not follow the slight corner rounding that JavaFX has and so you could see a gap.
  • Added unit tests for the ActionButtonWidget to test the properties.

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

Add a new widget preference to an action button that allows users
to change the corner radius.
Also update the representation so that alarm borders follow the
corner radius correctly.
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant