[LordIdra]

Adds an 'editing mode' checkbox to the alarm tree which enables/disables editing by controlling which items are shown in the context menu. Not very useful right now, but will be used extensively by planned future changes to the alarm tree

Checklist

• Testing:

  • The feature has automated tests
  • Tests were run
  • If not, explain how you tested your changes - tested manually

• Documentation:

  • The feature is documented
  • The documentation is up to date
  • Release notes:
    • Added an entry if the change is breaking or significant
    • Added an entry when adding a new feature

[georgweiss]

Shrinking the context menu in non-edit mode is a nice improvement, but gut feeling is that Enable/Disable alarms is used frequently enough to justify to keep them.

[georgweiss]

I'd also propose to add a toggle button next to the other buttons at the far right of the toolbar. That way the search feature would not have to "compete" with the checkbox for visual attention.

[LordIdra]

Shrinking the context menu in non-edit mode is a nice improvement, but gut feeling is that Enable/Disable alarms is used frequently enough to justify to keep them.

I was split on this, as technically it is a 'configuration' thing. But from a user perspective I think that this makes sense.

I'd also propose to add a toggle button next to the other buttons at the far right of the toolbar. That way the search feature would not have to "compete" with the checkbox for visual attention.

Yes, agreed. Although it is a little bit inconspicuous now. I have set it to enabled by default to avoid confusion. BTW what is the deal with icons? Do we source them from somewhere or make them ourselves?

Have made both changes (also moved the other 3 collapse/expand buttons to use internationalisation while I was at it), just need to change the icon

[georgweiss]

There is an "edit.png" icon in app/alarm/ui/src/main/resources/icons, I think that one would be OK.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.7% Duplication on New Code

See analysis details on SonarQube Cloud

[georgweiss]

@shroffk, I think this may be ready to merge.