Skip to content

Fix audio annunciator being unable to use audio files which have a space in their path - #3993

Open
LordIdra wants to merge 1 commit into
ControlSystemStudio:masterfrom
LordIdra:fix-audio-annunciator-file-paths-with-space
Open

LordIdra wants to merge 1 commit into
ControlSystemStudio:masterfrom
LordIdra:fix-audio-annunciator-file-paths-with-space

Conversation

@LordIdra

Copy link
Copy Markdown

closes #3992

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes - Audio annunciator crashed when I used paths with spaces in the settings file. Now runs fine with the same settings
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@LordIdra
LordIdra force-pushed the fix-audio-annunciator-file-paths-with-space branch from dda1b0a to dff8c8d Compare October 27, 2026 16:05
@sonarqubecloud

Copy link
Copy Markdown

@shroffk
shroffk requested a review from tynanford October 27, 2026 17:48
@shroffk

shroffk commented Oct 27, 2026

Copy link
Copy Markdown
Member

Argh!
I remember the previous issues with parsing special chars.

Should we be worried about any others? Should we have a core utility service/module to standardize.

@shroffk
shroffk self-requested a review October 27, 2026 17:51
@shroffk

shroffk commented Oct 27, 2026

Copy link
Copy Markdown
Member

@tynanford could you check this on a linux machine

@LordIdra

Copy link
Copy Markdown
Author

Argh! I remember the previous issues with parsing special chars.

Should we be worried about any others? Should we have a core utility service/module to standardize.

I was wondering the same after looking at the previous 2 issues. I don't know where else this would be an problem but I'm sure there are other places (time for some regexes?).

I should have thought to test on Linux as I am developing on WSL and compiling for windows - FWIW have just tested it and seems to work fine

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio annunciator unable to use audio files which have a space in their path

2 participants