Repository navigation
fix(confirm-write): render list items on the approval card like top-level values - #91
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summarize_argsbuilds the rows of theconfirm_writeapproval card. A top-level object renders as compact JSON, and a top-level boolean renders asYesorNo. Items inside a list skip those rules and go throughstr(), so the card shows Python's repr instead:pagesargument of a Notion page creation or thelinksof a Linear issue, renders as{'title': 'Q3 plan'}, {'title': 'Q4 plan'}.True, False.The approver reads these rows to decide whether to allow the write, so the card should present a list item the same way it presents the same value on its own.
Change
_stringifyformats each list or tuple item with_stringifyinstead ofstr(). Strings, numbers, and flat lists render exactly as before.test_summarize_args_renders_list_items_like_top_level_valuescovers a list of objects and a list of booleans.Testing
From
agent/:uv run pytest -q tests/test_write_confirmation.py: 53 passed. With only the source change reverted, the new test fails (1 failed, 52 passed) with"{'title': 'Q3 plan'}, {'title': 'Q4 plan'}".uv run pytest -q: 853 passed, 1 skipped.Fixes #90