Skip to content

Align the CMake project version with the 1.1.8 release - #55

Merged
Critlist merged 1 commit into
Critlist:masterfrom
neuhaus:fix/cmake-version-skew
Nov 11, 2026
Merged

Critlist merged 1 commit into
Critlist:masterfrom
neuhaus:fix/cmake-version-skew

Conversation

@neuhaus

@neuhaus neuhaus commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CMake declared 1.1.1 while the release is 1.1.8; PROJECT_VERSION feeds SAVE_VERSION. Bump it. Verified: the build now reports SAVE_VERSION 1.1.8.

CMakeLists.txt still declared 1.1.1 while the README and CHANGELOG are at
1.1.8. PROJECT_VERSION feeds SAVE_VERSION, so builds advertised the wrong
save version. Bump it to 1.1.8.
@Critlist

Copy link
Copy Markdown
Owner

Hey Sven, thanks for catching this! I'm going to close it, though, because the mismatch is on purpose. PROJECT_VERSION becomes SAVE_VERSION, which names the save directory, so bumping it would move saves from save/v1.1.1/ to save/v1.1.8/. Anyone upgrading, including AUR users, would suddenly find their existing saves missing from the game. The files would still be on disk, just not found. That's why release.sh never touches it.

That said, I'd be happy to take a PR that fixes this properly, either by giving the save directory its own constant or by adding a migration step that picks up the old directory. Then the version number can follow the releases like it should.

@Critlist Critlist closed this Nov 10, 2026
@Critlist Critlist reopened this Nov 11, 2026
@Critlist

Copy link
Copy Markdown
Owner

Hey Sven, I owe you an apology on this one. I closed it saying the version bump would hide people's saves, but I went back and checked: SAVE_VERSION is defined in CMake and never actually read by any of the C code. Saves always go to save/<uid><name> no matter what the version is. So your fix is safe and you were right. Sorry about that! Reopening it now.

@Critlist
Critlist merged commit 806c0b9 into Critlist:master Nov 11, 2026
14 checks passed
@neuhaus
neuhaus deleted the fix/cmake-version-skew branch November 14, 2026 11:19
neuhaus pushed a commit to neuhaus/restoHack that referenced this pull request Nov 15, 2026
Align the CMake project version with the 1.1.8 release
Critlist added a commit that referenced this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants