Repository navigation
Drop the dangling windows/pdcurses gitlink from master - #66
Merged
Merged
Conversation
windows/pdcurses was committed to master as a submodule gitlink, but .gitmodules has no entry for it, so `git submodule update --init --recursive` fails in a fresh clone with "No url found for submodule path 'windows/pdcurses'". That also breaks wasm builds and any CI that checks out submodules. The Windows port and its PDCurses submodule live on the windows-port branch; nothing on master references it. Reported by Sven Neuhaus in #61.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows/pdcurseswas committed to master as a submodule gitlink (in 2bb7b44), but.gitmoduleshas no entry for it. In a fresh clone,git submodule update --init --recursivefails:That breaks the wasm build setup and any CI that checks out submodules, including the GitHub Pages workflow planned in #61. The Windows port and its PDCurses submodule live on the
windows-portbranch, and nothing on master referenceswindows/pdcurses.The fix is
git rm --cached windows/pdcurses. I checked it in a fresh clone of this branch: submodule init now succeeds and checks outwasm/utwat the pinned commit.Thanks to @neuhaus for spotting this in #61.
🤖 Generated with Claude Code