Repository navigation
Conversation
Split the long sentences in the export docs and replace "would". Add the `error` row to the file entry table. Build the numbers in the `max_file_bytes` help text from the two cap constants and split its long sentence. Pin that an empty `file_counts` uses the default. Remove the comment on the file sort. The files of a line sort by id so the files that a full line drops are the same on every run.
6 tasks done
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two limits keep a product export small enough to stream and cheap to plan.
max_file_bytesnow accepts at most 104857600 (100 MiB). A larger value is a 400 that names the field.data_base64: nullanderror: "line_cap". The manifest'sfiles_over_capdoes not count it, because it is not over the file size cap.file_counts=false. Then it skips the storage stat for each file, still counts the files, and returnsfiles_over_cap: null. With the default, the manifest makes one storage call per file instead of two.Test results
python3 manage.py test unittests.test_apiv2_export unittests.test_apiv2_export_performance --keepdb: 59 tests, OK, on this branch on the latestdev.ruff check --config ruff.tomlon the changed files: clean.FileNotFoundErrorfor a missing object fails the call instead of marking the filemissing.Documentation
docs/content/automation/api/product_export.mddescribes both caps, theline_caperror andfile_counts.Checklist
dev.devbranch.docs/content/automation/api/product_export.md.