Repository navigation
chore(deps): rebuild dist with undici 7.30.1 and nested undici 6.29.1 - #109
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Contributor
DeployGate Upload Information
|
Member
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild
dist/index.jsso the bundledundiciversions include the latest security fixes.undici(7.29.1 → 7.30.0 → 7.30.1) without rebuildingdist/, so the shipped action still bundled 7.29.1 (last rebuilt in fix(deps): bump @actions/core to 2.0.3 and @actions/github to 8.0.1, rebuild dist #104). 7.30.1 contains several security fixes (e.g. GHSA-qrxm-fqhp-jwvm, GHSA-xjj6-f33q-929c), which only reach users oncedist/is rebuilt.@actions/core(via@actions/http-client) and@actions/githubdepend onundici@^6.23.0, which was locked at 6.29.0. This is also bundled intodist/and is flagged by Dependabot alerts chore(deps): bump undici from 7.26.0 to 7.27.2 in the other-dependencies group #84, chore(deps-dev): bump the development-dependencies group with 2 updates #86, chore(deps): bump the other-dependencies group with 2 updates #89, chore(deps-dev): bump prettier from 3.8.4 to 3.9.4 in the development-dependencies group #91, chore(deps-dev): bump prettier from 3.9.4 to 3.9.5 in the development-dependencies group #93 (fixed in 6.29.1).Changes
package-lock.json: nestedundici6.29.0 → 6.29.1 (npm update undici; within the existing^6.23.0range, nopackage.jsonchange)dist/index.js: rebuilt withnpm ci && npm run buildon Node 20.20.2 (matchesruns.using: node20)Verification
npm ls undici --allshows 7.30.1 (direct) and 6.29.1 (nested) onlybuild-and-uploadin this PR exercises the action end to endFollow-up
dist/: Add CI check to detect stale dist/ build #108