Repository navigation
refactor: Include Bluesky plan stubs by default - #1694
Draft
shree-iyengar-dls wants to merge 22 commits into
Draft
shree-iyengar-dls wants to merge 22 commits into
shree-iyengar-dls wants to merge 22 commits into
Conversation
shree-iyengar-dls
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 49 49
Lines 3791 3795 +4
=======================================
+ Hits 3657 3661 +4
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
abbiemery
requested changes
Oct 19, 2026
| dependencies = [ | ||
| "tiled[client]>=0.2.4", | ||
| "bluesky[plotting]>=1.14.0", # plotting includes matplotlib, required for BestEffortCallback in run plans | ||
| "bluesky[plotting] @ git+https://github.com/bluesky/bluesky.git@main", # plotting includes matplotlib, required for BestEffortCallback in run plans |
Contributor
There was a problem hiding this comment.
We cannot do git dependencies and have a published release.
Contributor
Author
There was a problem hiding this comment.
Yeah yeah. Just doing this for now until there's a new release of bluesky that has the new typing changes
Contributor
|
@shree-iyengar-dls I would put this in draft for now as this depends on a few different things which are yet to be merged e.g updated bluesky version, supporting *args and **kwargs |
Contributor
|
Unblocked partially by the merging of #1715, might still be blocked by a bluesky release. |
shree-iyengar-dls
force-pushed
the
1691_blueapi_plan_stubs
branch
from
October 23, 2026 09:31
d96a6fb to
b020927
Compare
shree-iyengar-dls
force-pushed
the
1691_blueapi_plan_stubs
branch
from
October 23, 2026 12:30
9ff9c16 to
e6ab3b5
Compare
…ce/blueapi into 1691_blueapi_plan_stubs
…ce/blueapi into 1691_blueapi_plan_stubs
Contributor
|
Blocked by #1720 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1691