Skip to content

Add Argo Workflow latency alerts - #1760

Open
hazdl wants to merge 3 commits into
mainfrom
hz/latency-alerts
Open

hazdl wants to merge 3 commits into
mainfrom
hz/latency-alerts

Conversation

@hazdl

@hazdl hazdl commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Analysis PlatformAP-1372

Summary

  • Add an alert for high P95 workflow-template runtime.
  • Add an alert for high P95 workflow queue latency.
  • Add an alert for high P95 workflow queue duration.
  • Include workflow template, namespace, and queue labels in alert descriptions where applicable.
  • Align alert labels with existing warning alerts.

Validation

  • Helm template rendering: Rendered the monitoring Helm chart successfully.
  • Prometheus rule validation: Validated the extracted alert rules using promtool check rules.
  • Alert thresholds and metric units: Reviewed the alert expressions, thresholds, and metric units against the relevant metric definitions.

Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated
Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated
Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated
@hazdl

hazdl commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

The metric is reported in seconds, so the existing threshold of 60 equates to 60 seconds. I've updated the threshold to 3600 (60 minutes) and adjusted the alert description accordingly.

@hazdl
hazdl force-pushed the hz/latency-alerts branch from 1b13b7e to 3669c03 Compare October 22, 2026 09:39
@hazdl
hazdl requested a review from JamesDoingStuff October 22, 2026 10:42
@hazdl
hazdl force-pushed the hz/latency-alerts branch from 5c542b9 to 4a0ddd5 Compare October 26, 2026 16:45
@hazdl
hazdl requested a review from a team October 26, 2026 16:45
@hazdl

hazdl commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Hi @JamesDoingStuff , could you please take another look at this PR when you get a chance? I’ve added a comment addressing the issue, but the PR is still blocked. Let me know if anything else is needed from my side. Thanks!

@JamesDoingStuff

Copy link
Copy Markdown
Collaborator

It looks like these alerts got a bit mixed up with the scraping ones when you rebased - please could you go through and make sure they're correct? Also, the Confirm the metric unit is seconds. lines can probably be done away with now

@hazdl
hazdl force-pushed the hz/latency-alerts branch 3 times, most recently from 02e75f4 to bbf179e Compare October 27, 2026 15:25
@hazdl

hazdl commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

@JamesDoingStuff Try now please.

@hazdl
hazdl force-pushed the hz/latency-alerts branch from bbf179e to 871450c Compare October 27, 2026 18:11

@JamesDoingStuff JamesDoingStuff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit pedantic on my part but could we have a bit of consistency with the commit scope please (the bit in brackets)? Three different scopes for one feature is a bit confusing. I'd suggest just monitoring

Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated
Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated
Comment thread charts/monitoring/alert-rules/alert-rules.tpl.yaml Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants