Repository navigation
Make sure that software installation prefix exists for site installations - #340
Conversation
|
Tested in EESSI/dev.eessi.io-riscv#136. Initially it already worked, but still tried to create some wrong paths as well: Fixed in 6a4f0ec by adding square brackets to that check. Confirmed by doing another build (EESSI/dev.eessi.io-riscv#136 (comment)) and that showed: Also used Finally, tested with a regular build in EESSI/software-layer#1903 (comment), which still worked fine. |
There was a problem hiding this comment.
Use of EESSI_SITE_SOFTWARE_PREFIX_BACKUP isn't super elegant, but I guess we have no other choice. Also, the test build at EESSI/software-layer#1903 (comment) doesn't use the latest commit in this PR. However, I checked and the subsequent two commits only affect things inside if-statements directly specific to site builds, so to speak with @ocaisa : I'll close my eyes to this and approve the change. Agreed with @bedroge that he'll buy everyone a beer if this breaks it.
On the whole, I think this is a good fix to something we overlooked when first implementing the site-building functionality. Thanks @bedroge
Currently site installations seem to fail when building for a new CPU target, see EESSI/dev.eessi.io-riscv#136. This will hopefully solve it by creating the installation prefix, which should ensure that the EESSI module will not error out.