Repository navigation
Conversation
LevelUniforms SIZE was one scalar short, causing a buffer overflow FrameUniforms SIZE was two scalar shorts, but align16 prevented the overflow
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LevelUniformsallocates 112 bytes, but 116 bytes are written. This results in a buffer overflow of 4 bytes.According to this AI report (djefrey/Colorwheel#88), the same bug in Colorwheel results in issues with Voxy.
FrameUniforms.SIZEis also incorrect, but thealign16inUniformBufferresults in a large enough malloc.Uniform buffers were tested by adding this code at the end of each
updateimplementation