Repository navigation
Fix for #9291. Missing final record count in gbak backup logs - #9292
Merged
hvlad merged 2 commits intoNov 13, 2026
Merged
Conversation
hvlad
approved these changes
Nov 13, 2026
| verbRecs = records; | ||
| BURP_verbose(108, SafeArg() << (verb * tdgbl->verboseInterval) /*records*/); | ||
| verbRecs = verb * tdgbl->verboseInterval; | ||
| BURP_verbose(108, SafeArg() << (verbRecs) /*records*/); |
hvlad
added a commit
that referenced
this pull request
Nov 13, 2026
…ds_log Fix for #9291. Missing final record count in gbak backup logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9291
Change
When the final buffer of a table crossed a reporting threshold,
gbakcould omit the exact final record count. For example, backing up 101 rows with-verbint 100ended with100 records writtenin the log.The final check now compares the actual total with the last reported value. It prints the exact total when needed and avoids a duplicate message when the values match. The backup format and data writing logic are unchanged.
Validation
The following cases were checked before and after the fix using
-verbint 100 -parallel 1:The backup of the 101-row table was restored successfully:
COUNT(*) = 101,MIN(ID) = 1, andMAX(ID) = 101.