Skip to content

chore(bigqueryconnection): remove superseded connection snippets - #10359

Merged
iennae merged 3 commits into
GoogleCloudPlatform:mainfrom
XrossFox:retire-bigqueryconnections-samples
Oct 24, 2026
Merged

iennae merged 3 commits into
GoogleCloudPlatform:mainfrom
XrossFox:retire-bigqueryconnections-samples

Conversation

@XrossFox

Copy link
Copy Markdown
Contributor

Description

Remove deprecated BigQuery Connection snippets (DeleteConnection, GetConnection, ListConnections, and UpdateConnection) and their corresponding integration tests, as they have been superseded by samples in googleapis/google-cloud-java.

Inline connection cleanup in the remaining integration tests' tearDown() methods so they no longer depend on DeleteConnection.

Fixes b/576442220

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

Remove deprecated BigQuery Connection snippets (`DeleteConnection`,
`GetConnection`, `ListConnections`, and `UpdateConnection`) and their
corresponding integration tests, as they have been superseded by
samples in `googleapis/google-cloud-java`.

Inline connection cleanup in the remaining integration tests'
`tearDown()` methods so they no longer depend on `DeleteConnection`.
@XrossFox
XrossFox requested review from a team and yoshi-approver as code owners October 23, 2026 22:22
@snippet-bot

snippet-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: bigqueryconnection Issues related to the BigQuery Connection API API. samples Issues that are directly related to samples. labels Oct 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several standalone connection classes (DeleteConnection, GetConnection, ListConnections, UpdateConnection) along with their integration tests. The remaining integration tests (CreateAwsConnectionIT, CreateConnectionIT, and ShareConnectionIT) are updated to perform connection cleanup directly in their tearDown methods. The review feedback highlights a potential issue where an exception during cleanup could prevent the restoration of the standard output stream, and suggests wrapping the cleanup logic in a try-finally block to ensure the stream is always restored.

@iennae
iennae merged commit 370270c into GoogleCloudPlatform:main Oct 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryconnection Issues related to the BigQuery Connection API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants