Repository navigation
Conversation
Remove deprecated BigQuery Connection snippets (`DeleteConnection`, `GetConnection`, `ListConnections`, and `UpdateConnection`) and their corresponding integration tests, as they have been superseded by samples in `googleapis/google-cloud-java`. Inline connection cleanup in the remaining integration tests' `tearDown()` methods so they no longer depend on `DeleteConnection`.
|
Here is the summary of changes. You are about to delete 4 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request removes several standalone connection classes (DeleteConnection, GetConnection, ListConnections, UpdateConnection) along with their integration tests. The remaining integration tests (CreateAwsConnectionIT, CreateConnectionIT, and ShareConnectionIT) are updated to perform connection cleanup directly in their tearDown methods. The review feedback highlights a potential issue where an exception during cleanup could prevent the restoration of the standard output stream, and suggests wrapping the cleanup logic in a try-finally block to ensure the stream is always restored.
Description
Remove deprecated BigQuery Connection snippets (
DeleteConnection,GetConnection,ListConnections, andUpdateConnection) and their corresponding integration tests, as they have been superseded by samples ingoogleapis/google-cloud-java.Inline connection cleanup in the remaining integration tests'
tearDown()methods so they no longer depend onDeleteConnection.Fixes b/576442220
Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions