Repository navigation
chore: enforce code style at build, fix Sonar Java and caching, narrow .gitignore - #205
Merged
Merged
Conversation
…w .gitignore - Raise code-style and naming rule severities from suggestion to warning, and configure IDE1006 so naming rules are enforced at build at all. - Sonar: drop the unused JDK 17 step (the scanner provisions JRE 21 itself), cache the scanner's real user cache, pin the scanner in .config/dotnet-tools.json and key the cache on that manifest. - .gitignore: remove the UTF-8 BOM and scope the DocFX patterns to docfx/. - Remove the samples generated_code section, which never matched samples/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four build-hygiene fixes.
Code style now fails the build (
.editorconfig)suggestiontowarning. Asuggestionis info-level, so even withEnforceCodeStyleInBuild+TreatWarningsAsErrorsit never failed the build.dotnet_diagnostic.IDE1006.severity = warning. Without it, the build ignores naming-rule severities: a probe withprivate int counterwas not flagged even atwarning. This also starts enforcing the existing async-suffix naming rule.Sonar workflow
What run 43043567906 shows:
setup-javadownloaded Zulu 17, then the scanner ignored it and provisioned its own JRE 21. Java 17 is no longer a supported scanner runtime: SonarQube Cloud dropped it on 2026-07-20, and SonarQube Server requires 21 from 2026.4. Thesetup-javastep is removed.${{ runner.temp }}\cache, which nothing writes to, so every run loggedPath Validation Error … no cache is being saved. It now caches~\.sonar\cache, where the scanner keeps its JRE, engine and plugins..config/dotnet-tools.jsonand restored each run. Dependabot's NuGet updater discovers only that path, not the rootdotnet-tools.jsonthe .NET 10 SDK creates by default. The JRE/plugin cache key hashes the manifest, so each scanner bump starts a fresh cache. There are no restore-keys, so stale plugins aren't carried forward..gitignore*.html,*.pdf,*.zip,*.manifest(and more) anywhere in the repo, plus anyapi/folder. It is now scoped to/docfx/_site/and/docfx/api/.*.log,*.tmpand*.cacheare still covered by the template entries.samples/no longer marked as generated code[**/samples/*/**.cs]never matched the repo-rootsamples/folder, because Roslyn needs at least one directory before**/samples. The section had no effect.samples/Directory.Build.props.Test plan
--verify-no-changes) passes🤖 Generated with Claude Code