Repository navigation
fix: reject DELETE statements missing a target table - #2843
Merged
manticore-projects merged 1 commit intoOct 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
DELETE, DELETE FROM, DELETE FROM WHERE ... and DELETE FROM USING ... all parsed successfully into a Delete with a null table, and toString() then printed the literal text "null" (DELETE FROM null WHERE 1 = 1). The grammar's bare-FROM alternative never required a table to follow. The production now validates that a target table was supplied in one of the three supported positions (before FROM, after FROM, or via the table list) through a requireDeleteSyntax() helper, matching the existing requireAccessSyntax()/requireReplicationSyntax() pattern.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE,DELETE FROM,DELETE FROM WHERE ...andDELETE FROM USING ...all parsed successfully. TheDelete()grammar's bare-FROMalternative never required a table to follow it, so aDeletewith a null table was produced andtoString()printed the literal textnull:The production now validates through a
requireDeleteSyntax()helper (same pattern as the existingrequireAccessSyntax()/requireReplicationSyntax()) that a target table was supplied in one of the three supported positions: beforeFROM, afterFROM, or in the pre-FROMtable list.DELETE t,DELETE FROM tandDELETE t1 FROM t1 JOIN t2keep parsing unchanged.