Repository navigation
refactor: share expression parsing fallback logic - #2844
Merged
manticore-projects merged 1 commit intoOct 22, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseExpressionandparseCondExpressionduplicated the simple/complex parsing attempts. Keep one fallback path inparseExpression, delegate conditional expression parsing to it, and extract a private overload for a single configured attempt.The first attempt still requires the complete input. A retry creates a fresh parser, reapplies the configuration callback, and honors the caller's partial-parsing setting. Public signatures and reported exception behavior are preserved.
Validation:
verifyon JDK 21: 11,879 tests, 25 skipped, zero failures or errors.checkon JDK 17: 11,897 tests, 25 skipped, zero failures or errors; grammar ambiguity, formatting, Checkstyle, PMD, SpotBugs, and coverage checks pass. The local Spotless baseline was set toupstream/masterwith an init script because this checkout uses a fork remote.CCJSqlParserUtilsignatures match the baseline, and the grammar is unchanged.AI assistance: prepared with Codex.