Repository navigation
feat: support wildcard arguments in Oracle VECTOR types - #2845
Merged
manticore-projects merged 1 commit intoOct 22, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle VECTOR declarations such as
VECTOR(*, FLOAT32)andVECTOR(3, *)currently fail to parse. Accept wildcard arguments for VECTOR types and retain them in the existingColDataTypeargument list, including the optional third storage-format argument.The wildcard is restricted to VECTOR arguments. Other type arguments, including existing MySQL vector declarations, keep their current behavior.
Validation covers default and Oracle parser configurations, case-insensitive type names, dense and sparse declarations, AST arguments, SQL deparsing and reparsing, following columns, and rejection of wildcards for other type names.
Oracle reference: Create Tables Using the VECTOR Data Type.
Checks: Maven
verifyon JDK 21 (11,889 tests, 25 skipped) and Gradlecheckon JDK 17 (11,907 tests, 25 skipped), with zero failures or errors. Gradle also passed grammar ambiguity, formatting, Checkstyle, PMD and SpotBugs checks. Local formatting checks used upstream/master as the comparison ref because origin/master belongs to the fork.A short JMH run of
JSQLParserBenchmark.parseSQLStatementsused JDK 17, the latest parser, 3 forks, 3 x 1-second warmups and 5 x 1-second measurements per fork. Baseline: 18.000 +/- 1.005 ms/op; this change: 18.016 +/- 1.116 ms/op. The intervals overlap; this run does not show a measurable slowdown.AI assistance: prepared with Codex.