Repository navigation
Read false values of the command-line tool's environment variables as false - #184
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command-line tool sets each boolean option with
bool(os.environ[varname]), so any non-empty value turns it on, including the values meant to turn it off:The only way to turn an option off was an empty value (
CHECK_DELIVERABILITY=).0,false,noandoff(in any case) are now read as false too; an empty value is still false and every other value still true.Added
test_main_boolean_environment_variable(withALLOW_DOMAIN_LITERALset to true and false spellings); the false spellings fail before the fix. Changelog entry under In Development