Repository navigation
More cert patches - #1567
Closed
SohierDane wants to merge 1 commit into
Closed
More cert patches#1567SohierDane wants to merge 1 commit into
SohierDane wants to merge 1 commit into
Conversation
SohierDane
added this pull request to stack #1568
October 20, 2026 21:38
Contributor
Author
|
@rosbo should I close this PR since we're planning on inheriting a patch from Colab? |
An error occurred while trying to automatically change base from
certifi-patch
to
main
October 21, 2026 20:01
Contributor
|
gcloud and grpc is being fixed upstream. I will rely on this to address these issues. |
SohierDane
removed this pull request from stack #1568
October 21, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the certifi/pip/uv patch (stacked on certifi-patch). The uv advisory says to check every package that ships its own copy of the CA bundle. A scan of the built CPU image found the compromised emSign ECC Root CA - G3 still
trusted outside of certifi/pip/uv. This PR removes it, or bypasses the copy where no fix exists yet.
Changes
Fixed upstream:
No upstream fix yet, so these now use the patched system bundle:
Each workaround has a "Remove once the base image ships …" comment, worded like the existing pillow pin. This PR also adds that comment to the earlier uv, certifi and pip changes.
The gcloud setting is an environment variable because gcloud config set --installation fails in this base image. gcloud can't find its install directory, so it ignores /tools/google-cloud-sdk/properties. That also means the base image's
disable_usage_reporting = True in that file has no effect, which is worth raising with the Colab team.
Testing
Built and tested on CPU (./build && ./test): 201 tests passed, 13 skipped.
Six new tests in tests/test_certifi.py; all six fail on the image before this change and pass after:
The GPU image was not built or tested locally (no GPU on the build machine); CI's GPU job needs to cover it.
Known remaining copies (not addressed)
A rescan of the new image still finds G3 in: