Repository navigation
fix(design-gate): let a prepared pair render a screen file - #11215
Conversation
A prepared pair could only render a shared component, so a change that only alters the props a route passes to an unchanged component had no comparable cell: the component renders the same on both revisions. The diagnostic source may now name a screen below apps/mobile/src/app, with its group and parameter segments. The router's own files stay refused: a layout is not a screen, and a + file is reserved for the not-found, HTML and native-intent hooks. Dotted segments are allowed in the route tree only, so no . or .. segment can leave the app.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe only change since the previous review is a formatting re-wrap of the Assumptions: Files Reviewed (2 files)
Previous Review Summary (commit 1292e01)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 1292e01)Status: No Issues Found | Recommendation: Merge Executive SummaryThe design-gate schema now admits screen files below Assumptions: Files Reviewed (2 files)
Reviewed by deepseek-flash-latest · Input: 38K · Output: 3.8K · Cached: 164.9K Review guidance: REVIEW.md from base branch |
|
bot: Prepared pair at head b5c636e, two diagnostic targets that name a screen file (
|
|
bot: Unprepared
Both runs are uploaded beside the prepared pair under this head in the factory design-gate bucket, in the |
|
bot: On the review note about the CLI usage text (
The remark was recorded as an assumption rather than a finding, so it needs no code change; the run at this head stays as it is. |





Evidence
Evidence: demonstrated — a prepared design-gate pair at this head rendered the repository picker and the branch picker from screen-file diagnostics on both revisions, each target in all four matrix cells, and
comparereturnedcomparablewith an emptyintroducedlist; the focused unit run passes 48 tests, including the new acceptance and rejection cases.What changed
dev/local/design-gate/baseline.ts: a target'sdiagnostic.componentmay now name a screen belowapps/mobile/src/appas well as a component belowapps/mobile/src/components. Route group and parameter segments are accepted there. The router's own files stay refused:_layout.tsxis not a screen, and a+-prefixed file is reserved for the not-found, HTML and native-intent hooks. A.or..segment stays refused in both trees, so a manifest cannot name a file outside the app.dev/local/design-gate/baseline.test.ts: the rejection list gains the layout,+-file and.tscases, and two acceptance cases cover a plain and a parameterised route.No screen, style or interaction of the app changes. The two files are the gate's own tooling; the app tree is untouched by this branch.
Why
A prepared pair could only render a shared component. When a change only alters the props a route passes to unchanged shared UI, that UI renders identically on both revisions, so no cell can show the difference and the comparison reports itself comparable while proving nothing. A screen file is the honest target for that shape of change, and several mobile picker changes take that shape.
Every existing guarantee holds: the source must be tracked in both revisions, the prepared source is hashed and validated, and a diagnostic still renders under
(auth)so a signed-out device can capture it.Verification
Focused unit run on this VM:
pnpm exec tsx --test dev/local/design-gate/baseline.test.ts ℹ tests 48 ℹ pass 48 ℹ fail 0Prepared pair at head
b5c636eaf, two diagnostic targets that name a screen file (repo-picker.tsx,branch-picker.tsx), base99ef995e(merge base) and the head, each revision served by its own Metro on its own port:pnpm -s dev:mobile:design-gate prepare --base 99ef995e… --head b5c636ea… \ --targets /tmp/pr-proof/targets-screen.json --out /tmp/pr-proof/prepared pnpm -s dev:mobile:design-gate compare --preparation …/preparation.json \ --base-run …/base --head-run … --out /tmp/pr-proof/comparison {"status":"comparable","introduced":[],"reasons":[]}prepareaccepted both screen sources and generated the fixtures in both worktrees. Head fixture forrepo-picker:unsettled,blank-frame,capture-alignment,env-mismatchorlink-unopenedfinding.b5c636ea…, base99ef995e…, fromproof-source.jsonand the loaded bundle marker.rect,text,roleandtestIDlists are identical between the two revisions in every cell.safe-areaon the sheet header: a diagnostic renders the sheet as a bare route, so the header sits under the status-bar inset. Both revisions report the same findings, so nothing is introduced by this change.1292e01covered five picker screens and comparedcomparablewith the same outcome.Design gate: 4 cells, 16 errors, 0 warnings
The base revision reports the same 16 findings, so no finding is introduced. One screen in the same flow cannot be a diagnostic target at all: it calls a hook that only the signed-in shell provides, and a diagnostic route renders signed out. Screen-level coverage for such a screen stays with its mounted test.
Unprepared run on the picker route
The same matrix ran in the plain
run --linkmode at both revisions. The signed-in route/agent-chat/repo-pickercannot be opened here (no backend on this VM: the bootstrap guard redirects to/login, and neither the grouped nor the ungrouped link form changed that), so the run used the prepared pair's own(auth)fixture route, which renders each revision'srepo-picker.tsx.safe-areaerrors, 0 warnings, nounsettled,blank-frame,capture-alignmentorenv-mismatch.safe-areaerrors.This is a prerequisite for a mobile picker change that can only be proved by rendering its screens; that change follows once this lands.
Production prerequisites
None.
Proxy answers
The proxy answered no questions.