Repository navigation
Use the ghost-cell spacing for the z one-sided viscous gradient - #2119
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
s_compute_fd_gradient's one-sided z derivative at idwbuff(3)%beg divided by z_cc(beg + 2) - z_cc(is3_viscous%beg). is3_viscous%beg is idwbuff(3)%beg + 1 there, so the denominator spanned one cell instead of two and the outermost ghost gradient was doubled on a uniform grid. Divide by z_cc(beg + 2) - z_cc(beg), matching the x and y stencils. The 27 3D Viscous tests pass against the existing goldens.
|
Claude Code Review Head SHA: 2db6102 Files changed:
Findings: |
sbryngelson
marked this pull request as draft
November 3, 2026 03:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2119 +/- ##
=======================================
Coverage 61.90% 61.90%
=======================================
Files 86 86
Lines 22948 22948
Branches 3386 3386
=======================================
Hits 14205 14205
Misses 6229 6229
Partials 2514 2514 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
s_compute_fd_gradient's one-sided z derivative atidwbuff(3)%begdivided byz_cc(beg + 2) - z_cc(is3_viscous%beg).is3_viscous%begisidwbuff(3)%beg + 1there, so the denominator spanned one cell instead of two and the outermost ghost gradient was doubled on a uniform grid.Divide by
z_cc(beg + 2) - z_cc(beg), matching the x and y stencils.Who it affects
3D viscous runs (
viscous = T) with the Reynolds-number flux path: the outermost ghost-layer z gradient at the lower z boundary.Verification
No existing golden changes: the 27 3D Viscous tests pass against the current goldens, so no test covers the affected ghost gradient.
Testing. Built with GPU offload (OpenMP, AMD) and ran the full test suite with this fix and three other independent fixes applied together: 729 tests in 4 shards, 0 failures (three shards on MI300A, one on MI250X).
Prepared with Claude Code (AI-assisted); I reviewed the change and ran the tests.