Repository navigation
Load bubble radii before the adv_n branch in the EE source - #2121
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
s_compute_bubble_EE_source filled Rtmp and Vtmp only in the .not. adv_n branch, but the R2Vav sum for bub_adv_src reads them whenever adap_dt is off. With adv_n = T and adap_dt = F the void fraction source was built from an unwritten private array. Fill Rtmp and Vtmp before the branch so both paths see the cell's radii and wall speeds. All 65 Bubbles tests and the bubblecollapse_adap example pass against the existing goldens; 1D -> Bubbles -> adv_n=T (105673CA) is bit-identical to master, so these tests do not exercise a nonzero R^2 V contribution on this path.
|
Claude Code Review Head SHA: c6156ab Files changed:
Findings: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2121 +/- ##
=======================================
Coverage 61.90% 61.90%
=======================================
Files 86 86
Lines 22948 22948
Branches 3386 3386
=======================================
Hits 14205 14205
Misses 6229 6229
Partials 2514 2514 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
s_compute_bubble_EE_sourcefilledRtmpandVtmponly in the.not. adv_nbranch, but the R2Vav sum forbub_adv_srcreads them wheneveradap_dtis off. Withadv_n = Tandadap_dt = Fthe void-fraction source was built from an unwritten private array.Fill
RtmpandVtmpbefore the branch so both paths see the cell's radii and wall speeds.Verification
All 65 Bubbles tests and the
bubblecollapse_adapexample pass against the existing goldens.1D -> Bubbles -> adv_n=T(105673CA) is bit-identical to master, so the existing tests do not exercise a nonzero R^2 V contribution on this path.Testing. Built with GPU offload (OpenMP, AMD) and ran the full test suite with this fix and three other independent fixes applied together: 729 tests in 4 shards, 0 failures (three shards on MI300A, one on MI250X).
Prepared with Claude Code (AI-assisted); I reviewed the change and ran the tests.