Repository navigation
Default and broadcast particle_cloud shell_axis in pre_process - #2123
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
pre_process reads particle_cloud(i)%shell_axis in s_sample_cloud_candidate but never gave it a default or broadcast it; only simulation, which does not use it, did both. Under file_per_process every rank samples the cloud itself, so non-root ranks placed hemisphere-shell particles with an uninitialized axis, and without a namelist value even rank 0 read garbage. Default it to 3 (+z) and broadcast it with the other hand-written particle_cloud members, mirroring simulation. Verified with a 3D hemisphere-shell cloud (shell_axis = 1, file_per_process, 20 particles): the IB state from 2 ranks now matches the 1-rank run exactly and every particle lies on the +x side.
Lines of Code
|
|
Claude Code Review Head SHA: 194e606 Files changed:
Findings: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pre_process reads particle_cloud(i)%shell_axis in s_sample_cloud_candidate
but never gave it a default or broadcast it; only simulation, which does
not use it, did both. Under file_per_process every rank samples the
cloud itself, so non-root ranks placed hemisphere-shell particles with an
uninitialized axis, and without a namelist value even rank 0 read
garbage.
Default it to 3 (+z) and broadcast it with the other hand-written
particle_cloud members, mirroring simulation.
Verified with a 3D hemisphere-shell cloud (shell_axis = 1,
file_per_process, 20 particles): the IB state from 2 ranks now matches
the 1-rank run exactly and every particle lies on the +x side.
Verification
Testing. Built with GPU offload (OpenMP, AMD) and ran the full test suite with this fix and seven other independent fixes applied together: 729 tests in 4 shards, 0 failures (two shards on MI300A, two on MI250X).
Prepared with Claude Code (AI-assisted); I reviewed the change and ran the tests.