Repository navigation
Exchange ib_markers halo cells in post_process before writing - #2126
Open
sbryngelson wants to merge 1 commit into
Open
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
The silo ib_markers field includes the ghost layers, but post_process reads only the interior, so the ghosts were 0 and overwrote the neighbor rank's real cells when the files were assembled. Fill them with the existing MPI buffer exchange.
|
Claude Code Review Head SHA: 83ae1dd Files changed:
Findings: |
Lines of Code
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The silo ib_markers field includes the ghost layers, but post_process
reads only the interior, so the ghosts were 0 and overwrote the
neighbor rank's real cells when the files were assembled. Fill them
with the existing MPI buffer exchange.
Verification
Testing. Built with GPU offload (OpenMP, AMD) and ran the full test suite with this fix and seven other independent fixes applied together: 729 tests in 4 shards, 0 failures (two shards on MI300A, two on MI250X).
Prepared with Claude Code (AI-assisted); I reviewed the change and ran the tests.