Repository navigation
fix(local): drop a backslash from a revised copy's download name - #2443
MohammadHijjawi97 wants to merge 1 commit into
Conversation
The character class in downloads.py read `\|` as an escaped pipe, so a backslash was never removed. A source named on macOS or Linux, or a suffix, could put one in the saved name, which Windows cannot save.
|
@MohammadHijjawi97 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
What
download_nameinmodules/artifacts/revised_copies/downloads.pynow drops a backslash from a revised copy's saved name, as it already drops<>:"/|?*and control characters. The character class read\|as an escaped pipe, so the backslash was never in it; it is now\|, as inagent/thread_folder/mirror_path.py.Why
docs/architecture/studio.mdsays the name has "the characters no file system takes dropped", but a backslash got through. A source whose name has one, which macOS and Linux allow (and the Docker build runs on Linux), kept it in the download name, and so did a?suffix=holding one. Windows reads it as a folder separator.Before (source-name case with POSIX path handling):
After:
How to test
Two new tests: the suffix case runs everywhere; the source-name case is skipped on Windows, whose paths split at a backslash. Without the fix, the suffix test fails with
'Plan (re\vised v2).docx' != 'Plan (revised v2).docx'.uv run ruff check .passes.Summary by CodeRabbit