Repository navigation
feat(yasgui): redesign the settings and make request settings global - #248
Merged
Merged
Conversation
The settings follow the settings window of textfold: pages grouped in the navigation with icons, each setting a row with one line about it and its control on the right, a fixed header and footer, and changes that apply at once (the footer says "Saved"; Done closes). A new General page holds the theme (Light, Dark or System), the editor themes, the request settings and what happens before a query runs. Request method, Accept headers and custom HTTP headers now apply to every tab, including tabs opened later. The formatter, auto-format and the CONSTRUCT check apply to every tab too and are kept across reloads. Settings > AI keeps the services as cards and gets a form with a provider list that fills in the base URL (still editable, with a reset), a link to get an API key, and Fetch models with a searchable model list. When a browser can't read a model list (CORS), the provider's known models are offered and the form explains what to do.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Redesigns the settings modal after the settings window of textfold, as agreed in the proposal.
Shell
settingsUi.ts.ThemeManager.getPreference()andfollowSystem().openSettings("request")still works and opens General.Global request settings
requestSettingsin the persisted config.addTabmerges the settings into new tabs, so tabs opened later get them too.addTab, such as a share link, still wins.editorSettings). Before, they were per editor and lost on reload.Settings → AI
Combobox.ts).listModelsnow flags a request that got no answer at all (AiRequestError.unreachable). In that case the form offers the provider's known models and explains what to do: a proxy, OpenRouter, or the CORS setting of Ollama or LM Studio.models/id prefix is dropped.providerId. Existing services are matched by their base URL, so no migration is needed.Other
openSettings("workspaces")instead of clicking the third nav button.Testing
Generated by Claude Code