Repository navigation
chore: ignore credential files - #76
Open
stevenjj33 wants to merge 1 commit into
Open
stevenjj33 wants to merge 1 commit into
stevenjj33 wants to merge 1 commit into
Conversation
A plugin that asks for an API key must not be able to commit one. The key files stay outside the checkout, but a .env written next to the plugin would have been tracked by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
.gitignoregrows a block that keeps credential files out of the checkout:Why
A plugin that asks the user for an API key must not be able to commit one. The key itself is written outside the checkout (
~/.config/agents/<name>.json, mode 0600, or an environment variable), so the exposure is narrow today — but a.envwritten next to the plugin, or acredentials.jsonproduced by a setup step, would be tracked by default. This block is the last line of defence for that..env.examplestays trackable on purpose: a template is exactly the file a plugin needs to publish.Verification
git check-ignoremarks.env,credentials.jsonand*.pemas ignored, and.env.exampleas trackable.A note on the patterns
They are deliberately specific. A broader
*secret*rule would have ignoredplugins/Fectivnfy112357/github-explore/skills/github-explore/scripts/tests/test_secret_redaction.py, which is a source file and not a credential.