Repository navigation
fix(financial_services): support banks beyond English and US conventions - #63
Merged
Merged
Conversation
…l retrieval Words are runs of letters, combining marks and decimal digits, compared after case folding and NFC normalization, so accented French and German words and ß match whole. English banks tokenize exactly as before. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
A region whose number format writes a decimal comma accepts its own renderings, 1 234,56 with any space or 1.234,56, and no longer reads 1,234 as 1234. English formats are unchanged. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
…p US-specific names The customer hears its balance in the region's currency and number format, and gives a date of birth in th region's date format. The kb_search example no longer names a US retirement product, open_account records a generic key, and PROMPT_VERSION moves to v1.2. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
The CLI offered only golden and dense, defaulting to dense, while the engine and its docs default to hybrid. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
… document vectors Packaged banks ship no document vectors, so each search paid for an embedding call whose result went unused. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Banks for other locales are next for
financial_services, and parts of its code assumed English text and US conventions: accented words retrieved poorly, amounts failed asset validation, and every customer heard a dollar balance and a US-format date of birth.épargne,ÜberweisungandStraßematch as written. English banks rank exactly as before.validate-assetsreads numbers in the bank's own format. A decimal-comma region accepts1 234,56(any space) or1.234,56, and doesn't read1,234as 1234. English formats are unchanged.$1,234.50,₹1,23,456.00,1 234,50 €), and dates of birth follow the region (month/day/year in the US, day.month.year in Germany, day/month/year elsewhere). Thekb_searchexample no longer names a US retirement product, andopen_accountno longer writes a key named after a US brand.PROMPT_VERSIONmoves to v1.2.hybridretrieval, matching the engine and the docs;denseandgoldenremain as ablations.How it was verified
make check-all: lint clean, 333 files already formatted.make test: 4100 passed, 2 failed. The two failures are intests/test_replay_reasoning_config.py, which read amodels.local.tomlwhen the checkout has one; they pass without it.make smoke,make check-license-headers,make check-doc-links,make check-notebooks-cleanandmake check-distpass.validate_bank), regional money and dates in prompts, the account key, thekb_searchexample, the CLI default and query embedding. Each fails without its change, and each commit passes on its own.en_US, 180 inen_IN).make health-checkagainst a custom provider config,financial_servicesinen_IN: simulate, eval and report all completed.en_INwith--scorers financial_services: the judge scored, the scorer returnedok, and the customer quoted a rupee balance and a day/month/year date of birth.Results impact
financial_servicesconversations change, andPROMPT_VERSIONv1.2 changes their trajectory ids.en_US: dates of birth unchanged, balances gain thousands separators.en_INand the India variants: balances in rupees with Indian digit grouping, dates of birth day/month/year. All locales: the second example in thekb_searchdescription changed. Retrieval for the English banks is unchanged.