Repository navigation
fix(server): keep old runtime status from failing sandbox restarts - #5237
Open
shiju-nv wants to merge 2 commits into
Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
marked this pull request as draft
November 4, 2026 05:31
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
6 tasks done
This was referenced Nov 4, 2026
shiju-nv
changed the title
get.k3s.io serves the latest install.sh from k3s master, so the pinned checksum broke when upstream changed the script. Download install.sh from the release tag matching k3s_version instead and pin its checksum. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com> Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
marked this pull request as ready for review
November 4, 2026 11:09
|
Label |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a sandbox restart, a periodic status check can still see the previous run's exited container or no container at all. That stale observation can mark the new start as failed. Protect the start until its driver operation settles, then retain the replacement's actual readiness or failure.
Related Issue
Closes #4932. Related: #4981 and #5114. Depends on #5204.
Continues @prekshivyas's published candidate in #4932 and shares reconciliation guards and lifecycle coverage with @TaylorMutch's #4983. This also handles atomic start ownership and legacy retries. Resolve the shared scope and landing order before merging; after #4983 lands, reduce this PR to the remaining changes.
Changes
Release Notes
Sandbox restarts no longer fail because a periodic check applies the previous run's state during the new start.
Testing
At head
7a6b2767, Branch Checks passed. The focused lifecycle regressions, server Clippy and formatting also passed; the lifecycle source is unchanged by the CI installer backport.The Docker runtime job and Podman runtime job passed on this head. Both ran the stop/start and retained-workspace cases; Docker also passed the SSH host-identity restart/recreation case.
The full E2E run is still running; its aggregate result remains pending.
Checklist