Skip to content

Bump default driver version to 620.70.06 - #3278

Merged
rajathagasthya merged 1 commit into
NVIDIA:mainfrom
abrarshivani:driver-620.70.06
Nov 21, 2026
Merged

rajathagasthya merged 1 commit into
NVIDIA:mainfrom
abrarshivani:driver-620.70.06

Conversation

@abrarshivani

@abrarshivani abrarshivani commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Issue

None.

Description

Make R620 TRD1 (620.70.06) the default driver on main.

  • Set the default driver version to 620.70.06 in the Helm chart values.
  • Set the NVIDIADriver sample to 620.70.06.
  • Point the OLM bundle's default driver image and alm-example at the 620.70.06-rhel9 digest.
  • Keep the previous 595.91.07 image in the bundle as driver-image-595.
  • Remove the EOL 610 and 615 driver images from the bundle.
  • Bump the e2e driver update target to 580.196.07, the latest 580 driver.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Checked the manifests render and the new image resolves.

  • Render the chart with helm template and confirm the driver version is 620.70.06.
  • Confirm the bundle digest matches nvcr.io/nvidia/driver:620.70.06-rhel9.

@abrarshivani
abrarshivani requested a review from a team as a code owner November 20, 2026 22:45

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Missing required issue linkage

The PR description lists no issue. The contribution process requires a linked issue assigned to the contributor, leaving that prerequisite unverified.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The NVIDIA driver sample and default driver version change from 595.91.07 to 620.70.06. The certified bundle updates the driver digest in its example, related-images list, and deployment environment. It also adds related-image and environment entries for the 595 driver image.

Merge Risk: Low · up to 60e89

This PR makes driver 620.70.06 the default. Existing installs that take the new chart defaults on upgrade may have their GPU driver upgraded, which can interrupt workloads. Users who need to stay on the current driver should pin driver.version. Otherwise the change is low risk.

Security architecture risk: Minimal · up to 60e89

The new bundle image references are internally consistent, and the previous image remains listed. The inspected changes do not expand permissions, weaken upgrade controls, or establish a new security or rollback failure.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The relevant exposure is driver execution and replacement on GPU nodes managed by the existing policy. ClusterPolicy reconciliation builds state for managed driver pods; NVIDIADriver reconciliation partitions node state by the existing driver-owner label before applying each owner's policy.

Trust Boundaries and Controls

  • observed — NVIDIADriver explicitly disables operator-environment fallback for its driver image and requires image configuration in the resource. The separate ClusterPolicy image builder prioritizes explicit resource configuration, rejects incomplete repository/image/version tuples, and otherwise supports the named environment fallback. The changed bundle references do not bypass these selection rules.

Resilience and Maintainability Implications

  • observed — The existing controller propagates state-manager errors, periodically requeues successful reconciliation, and removes upgrade-state labels when automatic upgrades are disabled. These controller-level mechanisms do not establish atomicity or complete recovery guarantees inside the delegated per-node upgrade implementation.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

Other comments: 1

deployments/gpu-operator/values.yaml: 1

192-192: Minor · Functional Correctness · Quick win

Flag the driver change on Helm upgrade.

If an existing installation enables the default NVIDIADriver CR and adopts the new chart defaults on upgrade, its rendered driver version changes from 595.91.07 to 620.70.06. With autoUpgrade enabled, this can trigger a driver upgrade and interrupt GPU workloads. Tell users to pin driver.version if they need to retain the existing driver.

As per path instructions, flag “any default whose change alters behaviour for existing installs on helm upgrade.”

Source: Path instructions

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6266dc3 and 60e8950.

Files selected for processing: 3

  • bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml
  • config/samples/nvidia_v1alpha1_nvidiadriver.yaml
  • deployments/gpu-operator/values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@tariq1890 tariq1890 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove references to DRIVER_IMAGE_610 and DRIVER_IMAGE_615. They are all EOL as of now.

@tariq1890

Copy link
Copy Markdown
Contributor

Let's update the TARGET_DRIVER_VERSION here

@tariq1890 tariq1890 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abrarshivani !

@rajathagasthya

Copy link
Copy Markdown
Contributor

@abrarshivani Commits need to be squashed.

Make R620 TRD1 (620.70.06) the default driver in the Helm chart,
the NVIDIADriver sample and the OLM bundle. The bundle keeps the
previous 595.91.07 image as driver-image-595 and drops the EOL 610
and 615 images.

Bump the e2e driver update target to 580.196.07, the latest driver
on the 580 branch.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>
@rajathagasthya
rajathagasthya merged commit d338c6b into NVIDIA:main Nov 21, 2026
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants