You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NVIDIA driver sample and default driver version change from 595.91.07 to 620.70.06. The certified bundle updates the driver digest in its example, related-images list, and deployment environment. It also adds related-image and environment entries for the 595 driver image.
Merge Risk: Low · up to 60e89
This PR makes driver 620.70.06 the default. Existing installs that take the new chart defaults on upgrade may have their GPU driver upgraded, which can interrupt workloads. Users who need to stay on the current driver should pin driver.version. Otherwise the change is low risk.
Security architecture risk: Minimal · up to 60e89
The new bundle image references are internally consistent, and the previous image remains listed. The inspected changes do not expand permissions, weaken upgrade controls, or establish a new security or rollback failure.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The relevant exposure is driver execution and replacement on GPU nodes managed by the existing policy. ClusterPolicy reconciliation builds state for managed driver pods; NVIDIADriver reconciliation partitions node state by the existing driver-owner label before applying each owner's policy.
Trust Boundaries and Controls
observed — NVIDIADriver explicitly disables operator-environment fallback for its driver image and requires image configuration in the resource. The separate ClusterPolicy image builder prioritizes explicit resource configuration, rejects incomplete repository/image/version tuples, and otherwise supports the named environment fallback. The changed bundle references do not bypass these selection rules.
Resilience and Maintainability Implications
observed — The existing controller propagates state-manager errors, periodically requeues successful reconciliation, and removes upgrade-state labels when automatic upgrades are disabled. These controller-level mechanisms do not establish atomicity or complete recovery guarantees inside the delegated per-node upgrade implementation.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The reason will be displayed to describe this comment to others. Learn more.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
Other comments: 1
deployments/gpu-operator/values.yaml: 1
192-192: Minor · Functional Correctness · Quick win
Flag the driver change on Helm upgrade.
If an existing installation enables the default NVIDIADriver CR and adopts the new chart defaults on upgrade, its rendered driver version changes from 595.91.07 to 620.70.06. With autoUpgrade enabled, this can trigger a driver upgrade and interrupt GPU workloads. Tell users to pin driver.version if they need to retain the existing driver.
As per path instructions, flag “any default whose change alters behaviour for existing installs on helm upgrade.”
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Make R620 TRD1 (620.70.06) the default driver in the Helm chart,
the NVIDIADriver sample and the OLM bundle. The bundle keeps the
previous 595.91.07 image as driver-image-595 and drops the EOL 610
and 615 images.
Bump the e2e driver update target to 580.196.07, the latest driver
on the 580 branch.
Signed-off-by: Abrar Shivani <ashivani@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
None.
Description
Make R620 TRD1 (620.70.06) the default driver on main.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Checked the manifests render and the new image resolves.
helm templateand confirm the driver version is 620.70.06.