Skip to content

chore: use pages-staging-scoped role for PR previews - #605

Merged
John McCall (lowlydba) merged 1 commit into
mainfrom
lowlydba-ci-pages-staging-scoped-role
Nov 4, 2026
Merged

John McCall (lowlydba) merged 1 commit into
mainfrom
lowlydba-ci-pages-staging-scoped-role

Conversation

@lowlydba

Copy link
Copy Markdown
Contributor

Resolves #604

Switches PR previews to the pages-staging-scoped-oidc-overturemaps role and adds environment: staging to the cleanup job (deploy already has it).

Blocked: do not mark ready until OvertureMaps/omf-core-data-opentofu#149 is applied.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Signed-off-by: John McCall <john@overturemaps.org>
@lowlydba John McCall (lowlydba) changed the title ci: use pages-staging-scoped role for PR previews chore: use pages-staging-scoped role for PR previews Nov 4, 2026
@lowlydba
John McCall (lowlydba) force-pushed the lowlydba-ci-pages-staging-scoped-role branch from e2d121d to a68b96b Compare November 4, 2026 15:03
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ JAVASCRIPT eslint 33 0 0 22.43s
✅ MARKDOWN markdownlint 286 0 0 0.54s
✅ SQL sqlfluff 79 0 0 6.48s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters JAVASCRIPT_ES,MARKDOWN_MARKDOWNLINT,SQL_SQLFLUFF

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@lowlydba
John McCall (lowlydba) marked this pull request as ready for review November 4, 2026 15:05
@lowlydba
John McCall (lowlydba) requested a review from a team as a code owner November 4, 2026 15:05
Copilot AI balanced review requested due to automatic review settings November 4, 2026 15:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The blocking trust-policy update in OvertureMaps/omf-core-data-opentofu#149 was inaccessible for verification, and preview deployment and closed-PR cleanup still require validation with the scoped role.

No open issues 🎉

What changed in this PR

Updates documentation PR previews to use the repository-scoped AWS OIDC role, addressing #604 and restricting access to the repository’s preview prefix.

Changes:

  • Switches deploy and cleanup workflows to pages-staging-scoped-oidc-overturemaps.
  • Adds environment: staging to cleanup to satisfy the scoped role’s trust requirements.

The rollout remains blocked until OvertureMaps/omf-core-data-opentofu#149 is applied.

File Description
.github/​workflows/​staging_deploy.yaml Uses the scoped role for preview deployment.
.github/​workflows/​staging_deploy_cleanup.yaml Uses the scoped role and staging environment for preview cleanup.

Review effort: Balanced

@lowlydba
John McCall (lowlydba) merged commit 1d0c6ef into main Nov 4, 2026
17 of 18 checks passed
@lowlydba
John McCall (lowlydba) deleted the lowlydba-ci-pages-staging-scoped-role branch November 4, 2026 18:49

This branch was successfully deployed

1 active deployment
staging — a68b96b9 Deployed Nov 4, 2026 by lowlydba via Cleanup #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PR previews to the pages-staging-scoped OIDC role

3 participants