You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This repository does not receive automatic reviews because it has fewer than 10 stars.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 03f1aa1f-532b-4900-865c-8c0f8876c696
No actionable comments were generated in the recent review.
Walkthrough
The change adds question metadata and validation types, version-cloning support, and three version-2 form migrations for contact follow-up, TPT follow-up, and TB counselling. The migrations update questions, options, validations, conditions, ordering, and back-fill or post-submit flags.
Changes: Dynamic form version migrations
Layer / File(s)
Summary
Question metadata and version cloning src/main/java/com/iemr/flw/domain/iemr/QuestionValidation.java, src/main/java/com/iemr/flw/domain/iemr/SectionQuestion.java, src/main/java/com/iemr/flw/dto/iemr/SectionQuestionDTO.java, src/main/java/com/iemr/flw/masterEnum/ValidationType.java, src/main/java/com/iemr/flw/service/impl/DynamicFormReconciliationServiceImpl.java, src/main/java/com/iemr/flw/seeder/migration/FormVersionCloner.java
Adds question back-fill and post-submit edit flags, new validation types, reconciliation updates for non-null flag values, and a component that clones a form version while clearing nested entity IDs.
Contact follow-up form migration src/main/java/com/iemr/flw/seeder/migration/V010_RestructureContactFollowUpStatus.java, src/main/java/com/iemr/flw/seeder/ContactFollowUpFormSeeder.java
Adds version 2 with revised questions, options, conditional display rules, validations, ordering, and question flags. Removes comments about routing in the existing seeder; the question and options remain unchanged.
No confirmed defect currently blocks merging. Resolve the commitlint revision-range failure and complete normal checks before merging.
Pre-merge checks: 3 · 1 · 1
Failed checks: 1 warning · 1 inconclusive
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check
The title "Feature/dynamic form changes" is vague and generic. It names the area (dynamic forms) but not the main change. The changeset covers a new SectionQuestion backfill and edit-after-submit flag…
Rewrite the title to name the primary change. For example: "Add form version migrations for contact follow-up, TPT, and TB counselling forms" or "Add back-fill and edit-after-submit flags to dynamic form questions." Include the JIRA key STO…
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 9 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Full details: Title check
Explanation
The title "Feature/dynamic form changes" is vague and generic. It names the area (dynamic forms) but not the main change. The changeset covers a new SectionQuestion backfill and edit-after-submit flags, new ValidationType values (UNIT, helper text, AUTO_FILL), a FormVersionCloner, and migrations V010 to V012 that restructure the contact follow-up and TPT follow-up forms and add TB counselling helper text. The title uses the generic term "changes" and does not identify any of these.
Resolution
Rewrite the title to name the primary change. For example: "Add form version migrations for contact follow-up, TPT, and TB counselling forms" or "Add back-fill and edit-after-submit flags to dynamic form questions." Include the JIRA key STOP-602 if the team uses it in titles.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
@sehjotsinghunthinkable I’ll trigger a code review of this PR.
Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@sehjotsinghunthinkable I’ll trigger a code review of this PR.
Action not completed
Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID: STOP-602
Summary by CodeRabbit