Repository navigation
Use timevarying depth support for Croco fields - #3046
Open
erikvansebille wants to merge 39 commits into
Open
erikvansebille wants to merge 39 commits into
erikvansebille wants to merge 39 commits into
Conversation
for more information, see https://pre-commit.ci
…/Parcels into sigma-vertical-grid-support
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/Parcels into sigma-vertical-grid-support
for more information, see https://pre-commit.ci
…/Parcels into sigma-vertical-grid-support
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
for more information, see https://pre-commit.ci
…han dims tuple. Removed ti/tau warning from grid.search functions.
for more information, see https://pre-commit.ci
Because of Compatibility issue between xroms v0.6.1 and xgcm v0.10.1
As we now use the 4D depth support in Parcels v4
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we support CROCO data in Parcels. With the addition of time-varying sigma support in #2933, there is no need anymore for special sigma-kernels. This makes working with CROCO data as simple as working with any other sigma-grid data
Note that there is a compatibility issue between xroms v0.6.1 and xgcm v0.10.1, which I have no temporarily monkey-patched in the convert_croco3D tutorial
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
Support with patching the compatibility issue between xgcm and xroms