Repository navigation
docs: expand photo.getByBounds reference - #80
Merged
aeifn merged 4 commits intoNov 19, 2026
Merged
Conversation
aeifn
reviewed
Nov 18, 2026
aeifn
left a comment
Member
There was a problem hiding this comment.
I found two API contract issues in photo.getByBounds that affect both the English and Russian references.
- [P2] Clarify what the polygon selects in cluster mode. With
localWork: false, the server selects clusters by their grid positiong. Near the polygon boundary, this can include photos outside the polygon or omit photos inside it. Make the object-level containment guarantee specific tolocalWork: true. Cluster queries - [P2] Specify that the year filter matches the object's first year. Both modes filter on
yearalone. An object dated 1930–1940 is excluded by a request for 1936–1936 even though its date range overlaps the requested year. Direct lookup · Cluster lookup
Contributor
Author
|
Addressed both review points in 6f400f6. The reference now limits object-level polygon containment to |
Contributor
Author
|
Additional contract audit in 6835089 documents that direct lookup has no server-side limit or pagination and that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
photo.getByBoundsmodes controlled bylocalWorkstartAt, and errorsChecks
yarn lint:spellingyarn buildgit diff --checkBy submitting this contribution, I agree to license it under CC BY 4.0.