Repository navigation
Conversation
The Dancing Dervish's mods were never separated from the player's as the special handling checked for a skill id that no longer exists, so its global accuracy and movement speed always applied. Weapons disabled by Manifest Dancing Dervishes were also only handled late in CalcPerform, after weapon flags, conditions, Hollow Palm Technique's off hand and Hide of the Vendigo had been set up using the sword. Determine it in CalcSetup before the weapon data is built so both weapon slots count as empty. Battlemage and Spellblade no longer use the disabled weapon, and the Dervish minions keep using the sword. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bility Skills socketed in the weapons disabled by Manifested Dancing Dervishes (e.g. auras) can no longer be used. Supports socketed in them still support the Manifest Dancing Dervishes skill. Hide of the Vendigo makes you count as using a Claw for which skills can be used, so skills that can be used Unarmed but not with a Claw (Smite) are disabled. With Hollow Palm Technique, Claw skills (Cobra Lash) are no longer disabled by the unarmed off hand; they only attack with the main hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hide of the Vendigo only decides which skills can be used, based on the main hand. Once a skill can be used, the unarmed off hand from Hollow Palm Technique attacks with it as well, unless the skill is dual wield only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The weapon checks overwrote the reason with "No usable weapon equipped", so the check now runs after them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Work out whether the weapon slots are disabled before the items are processed, and leave the disabled weapons out of the equipped item list (keeping them in disabledItemList for their requirements and for minions that use them). Everything that reads the equipped items then sees empty weapon slots, so the Dancing Dervish specific workarounds for its modifiers, Battlemage, Spellblade and the off hand conditions are no longer needed. Rampage from the Dancing Dervish still applies. Item-granted skill groups are only created after the items are processed, so the calculation is redone if that changes whether the weapons are disabled, e.g. right after equipping The Dancing Dervish. Skills granted by an item being replaced when comparing items no longer disable the weapon slots. Only the skill that disables the weapons is exempt from being disabled when it comes from a weapon slot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without an off hand hit the test compared nil with nil and passed on dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Palm Regression test for PathOfBuildingCommunity#10516. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8696.
Fixes #10516.
Description of the problem being solved:
When Manifest Dancing Dervishes is active, its "Weapon Disabled" buff should disable both weapon slots. PoB only partly applied this, which caused several bugs:
CalcSetuplooked for the granted skill idUniqueAnimateWeapon, which no longer exists (the skill is nowManifestDancingDervishes). So that handling never ran, and the weapon's mods always went into the player's modDB.DisableWeaponswas only handled late inCalcPerform, where it swappedweaponData1to unarmed. By then the skill weapon flags, the weapon conditions (UsingSword,UsingTwoHandedWeapon,UsingMeleeWeapon, ...) and support matching had already used the sword. Unarmed attacks therefore got Sword / Two Handed / Weapon modifiers, while modifiers to Unarmed Attacks (which check the weapon flag) didn't apply.itemList["Weapon 1"]is empty, and the Dervish still occupies that slot. So there was no dual wielding, and main-hand-only modifiers such as Ambidexterity's "60% increased Attack Damage with Main Hand while Dual Wielding" applied to every hit.itemList["Weapon 1"], so Claw-only skills stayed disabled.itemList["Weapon 1"].Hide of the Vendigo also had two skill usability issues, both checked in game. They aren't specific to the Dervish:
Changes:
CalcSetupworks out whether an active socket group has aDisableWeaponsskill before the items are processed, using the same gating as active skill creation and buff application (main group or enabled group in the active weapon set, gem enabled, global effect enabled, buffs mode). The result is stored asenv.player.weaponsDisabled.env.player.disabledItemListinstead ofitemList, and their mods aren't added, except the Dancing Dervish'sRampage(the dervishes die when Rampage ends). Their requirements still count. Everything that reads the equipped weapons then sees empty slots without special-casing: weapon data, weapon flags and conditions, Hollow Palm, Hide of the Vendigo, Battlemage, Spellblade, Energy Blade,UsingShield/OffHandIsEmpty/Unencumbered. The broken Dervish special case and the late weapon swap inCalcPerformare removed.initEnvruns once more (override.weaponsDisabledRechecked), like the existing Energy Blade re-run. Item comparison tooltips ignore the granted skill of the item being replaced.disabledItemList. Minion DPS is unchanged, except that auras socketed in the disabled weapon (now disabled) no longer affect the Dancing Dervishes.asThoughUsing) decide which skills you can use. If the main hand can use the skill, the unarmed Hollow Palm off hand attacks with it too, unless the skill is dual wield only.Turning off the Manifest Dancing Dervishes socket group still gives the normal armed behaviour (weapon mods apply, attacks use the sword).
Steps taken to verify a working solution:
spec/System/TestDancingDervish_spec.luawith 15 tests. Each one checks the result with the dervishes manifested and, where relevant, with the group disabled:TestAttacks_spec.lua: Smite is disabled, Cobra Lash and Spectral Throw (Spectral Throw cannot be used with Hide of the Vendigo #10516) with Hollow Palm attack with both hands, Cyclone with Hollow Palm still attacks with both hands, and Dual Strike with Hollow Palm is still disabled.Link to a build that showcases this PR:
https://pobb.in/GIzUP6PXCv8E
Before and after screenshots:
🤖 Generated with Claude Code
(reviewed and tested by me, the human telling claude to do stuff)