Skip to content

Add Fleshrend stacks config for Pact of Ghorr - #10531

Open
lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/pact-of-ghorr-fleshrend-stacks
Open

lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/pact-of-ghorr-fleshrend-stacks

Conversation

@lucaskarsten

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Pact of Ghorr grants Hunger of Ghorr, which periodically triggers Fleshrend (skills["TriggeredBloodrend"] in Data/Skills/other.lua). Fleshrend's debuff stacks up to 3 times and has bloodrend_debuff_damage_over_time_taken_+%_per_stack = 25, i.e. "25% increased Damage over Time taken" per stack. That debuff is a large part of why DoT builds use the Pact, but PoB had no way to include it, so builds with Pact of Ghorr only saw the Empowered part.

The debuff lasts a short time and Fleshrend fires on an interval, so how many stacks are up depends on the fight. Following the other enemy stack options (Cinderflame, Mania), this adds a config count instead of guessing an uptime:

  • New option in Skill Options, under "Pact of Ghorr:" (shown only with Pact of Ghorr): "# of Fleshrend stacks on enemy". Each stack applies 25% increased Damage over Time taken to the enemy as a Fleshrend debuff, capped at 3.

Steps taken to verify a working solution:

  • New test in spec/System/TestSkills_spec.lua: with Creeping Frost and Pact of Ghorr, no mod at 0 stacks; 3 stacks gives 75% and 1.75x the DoT DPS; 5 stacks is still capped at 75%. It fails on dev and passes on this branch; removing the cap makes it fail.
  • Full busted suite: 746 successes, 0 failures.
  • --tags=builds (the saved 3.13 builds): the same 900 failures, with identical messages, on dev and on this branch.

Link to a build that showcases this PR:

Any DoT spell build with Pact of Ghorr (e.g. Creeping Frost or a Corrupting Fever Elementalist).

Before screenshot:

No Fleshrend option; enemy DoT taken unaffected by Pact of Ghorr.

After screenshot:

Skill Options > Pact of Ghorr: "# of Fleshrend stacks on enemy" = 3, enemy shows 75% increased Damage over Time taken from Config (Fleshrend).

Hunger of Ghorr triggers Fleshrend, whose debuff stacks up to 3 times and makes
the enemy take 25% increased Damage over Time per stack. PoB did not model it.
Add a Skill Options count, shown with Pact of Ghorr, that applies the debuff to
the enemy, capped at 3 stacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant