Repository navigation
Add Fleshrend stacks config for Pact of Ghorr - #10531
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
Hunger of Ghorr triggers Fleshrend, whose debuff stacks up to 3 times and makes the enemy take 25% increased Damage over Time per stack. PoB did not model it. Add a Skill Options count, shown with Pact of Ghorr, that applies the debuff to the enemy, capped at 3 stacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Pact of Ghorr grants Hunger of Ghorr, which periodically triggers Fleshrend (
skills["TriggeredBloodrend"]inData/Skills/other.lua). Fleshrend's debuff stacks up to 3 times and hasbloodrend_debuff_damage_over_time_taken_+%_per_stack= 25, i.e. "25% increased Damage over Time taken" per stack. That debuff is a large part of why DoT builds use the Pact, but PoB had no way to include it, so builds with Pact of Ghorr only saw the Empowered part.The debuff lasts a short time and Fleshrend fires on an interval, so how many stacks are up depends on the fight. Following the other enemy stack options (Cinderflame, Mania), this adds a config count instead of guessing an uptime:
Steps taken to verify a working solution:
spec/System/TestSkills_spec.lua: with Creeping Frost and Pact of Ghorr, no mod at 0 stacks; 3 stacks gives 75% and 1.75x the DoT DPS; 5 stacks is still capped at 75%. It fails ondevand passes on this branch; removing the cap makes it fail.--tags=builds(the saved 3.13 builds): the same 900 failures, with identical messages, ondevand on this branch.Link to a build that showcases this PR:
Any DoT spell build with Pact of Ghorr (e.g. Creeping Frost or a Corrupting Fever Elementalist).
Before screenshot:
No Fleshrend option; enemy DoT taken unaffected by Pact of Ghorr.
After screenshot:
Skill Options > Pact of Ghorr: "# of Fleshrend stacks on enemy" = 3, enemy shows 75% increased Damage over Time taken from Config (Fleshrend).