Skip to content

DINO-1190: use CI's auto gen'd github token during docker build of LA… - #1092

Merged
tahminator merged 1 commit into
mainfrom
DINO-1190
Nov 19, 2026
Merged

tahminator merged 1 commit into
mainfrom
DINO-1190

Conversation

@tahminator

@tahminator tahminator commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

…SS to avoid rate limiting (from 60/hour per IP to 1,000/hour per repository)

Description of changes

Checklist

  • I self-reviewed this PR
  • All AI comments are fixed or resolved before requesting review
  • CI is green
  • Database changes follow the db repo rules, or this PR does not change the database. Comment /migrate to apply migrations to staging (Codebloom team only).
  • I QA'd this in dev and attached screenshots below. If staging could not be checked, say why.

Screenshots

Dev

Staging

Summary by CodeRabbit

  • Chores
    • Updated the image build process to provide a GitHub credential during dependency synchronization.
    • Updated the build tooling dependency. Existing image build behavior remains otherwise unchanged.

@tahminator
tahminator requested a review from a team November 19, 2026 20:49
@tahminator
tahminator enabled auto-merge (squash) November 19, 2026 20:50
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The build-image action passes github.token to the build script. The script supplies it as a Docker build secret, and the Dockerfile mounts the secret for dependency synchronization. The pipeline dependency range also changes.

Changes: Image Build Token

Layer / File(s) Summary
Pass token into image builds
.github/composite/build-image/action.yml, .github/scripts/build-image/index.ts, .github/scripts/package.json
The action passes github.token to the script. The script parses the token and supplies it as the GITHUB_TOKEN build secret. The @tahminator/pipeline dependency range changes to ^1.0.104.
Mount token for dependency sync
internal/leetcode-auth-stealer-service/Dockerfile
The dependency-sync instruction requires and mounts GITHUB_TOKEN as a build secret.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant BuildImageAction
  participant BuildImageScript
  participant DockerClient
  participant DependencySync
  BuildImageAction->>BuildImageScript: Pass --githubToken from github.token
  BuildImageScript->>DockerClient: Supply GITHUB_TOKEN build secret
  DockerClient->>DependencySync: Mount GITHUB_TOKEN for dependency synchronization
Loading

Suggested labels: github_actions

Suggested reviewers: angelayu0530, naanci

Merge Risk: Moderate · up to 81f49

The change does not deliver its stated goal of avoiding GitHub API rate limiting in the LASS image build. The LASS workflow path never passes the token, and the pinned camoufox version does not use it for its release lookup. The new required secret mount can also make the build fail. Resolve both before merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…SS to avoid rate limiting (from 60/hour per IP to 1,000/hour per repository)
@sonarqubecloud

Copy link
Copy Markdown

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-stealer-service/tags under the following tags:

  • codebloom-leetcode-auth-stealer-service:staging-latest
  • codebloom-leetcode-auth-stealer-service:staging-2026.11.19-15.51.01
  • codebloom-leetcode-auth-stealer-service:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-stealer-service-arm/tags under the following tags:

  • codebloom-leetcode-auth-stealer-service-arm:staging-latest
  • codebloom-leetcode-auth-stealer-service-arm:staging-2026.11.19-15.51.07
  • codebloom-leetcode-auth-stealer-service-arm:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-service-arm/tags under the following tags:

  • codebloom-leetcode-auth-service-arm:staging-latest
  • codebloom-leetcode-auth-service-arm:staging-2026.11.19-15.51.08
  • codebloom-leetcode-auth-service-arm:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-standup-bot/tags under the following tags:

  • codebloom-standup-bot:staging-latest
  • codebloom-standup-bot:staging-2026.11.19-15.51.07
  • codebloom-standup-bot:staging-c5c0bb6

@sonarqubecloud

Copy link
Copy Markdown

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-standup-bot-arm/tags under the following tags:

  • codebloom-standup-bot-arm:staging-latest
  • codebloom-standup-bot-arm:staging-2026.11.19-15.51.08
  • codebloom-standup-bot-arm:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom/tags under the following tags:

  • codebloom:staging-latest
  • codebloom:staging-2026.11.19-15.53.21
  • codebloom:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-service/tags under the following tags:

  • codebloom-leetcode-auth-service:staging-latest
  • codebloom-leetcode-auth-service:staging-2026.11.19-15.51.13
  • codebloom-leetcode-auth-service:staging-c5c0bb6

@pat-agent

pat-agent Bot commented Nov 19, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-arm/tags under the following tags:

  • codebloom-arm:staging-latest
  • codebloom-arm:staging-2026.11.19-15.53.35
  • codebloom-arm:staging-c5c0bb6

@tahminator
tahminator merged commit 78cff34 into main Nov 19, 2026
28 of 29 checks passed
@tahminator
tahminator deleted the DINO-1190 branch November 19, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants