Skip to content

Fix leaderboard filter E2E URL assertions - #1094

Merged
tahminator merged 1 commit into
mainfrom
fix/e2e-leaderboard-filter-url
Nov 21, 2026
Merged

tahminator merged 1 commit into
mainfrom
fix/e2e-leaderboard-filter-url

Conversation

@tahminator

@tahminator tahminator commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Description of changes

Update the club filter E2E test to validate the consolidated filters=gwc URL parameter used by the frontend, rather than the legacy gwc=true parameter. This keeps the URL assertions aligned with the filter hook's active-filter serialization behavior.

Checklist

  • I self-reviewed this PR
  • All AI comments are fixed or resolved before requesting review
  • CI is green
  • Database changes follow the db repo rules, or this PR does not change the database. Comment /migrate to apply migrations to staging (Codebloom team only).
  • I QA'd this in dev and attached screenshots below. Staging/dev E2E could not be fully rerun locally because the environment did not have pnpm available.

Screenshots

Dev

No screenshot required; this change only updates E2E URL assertions.

Staging

Not checked.

Summary by CodeRabbit

  • Tests
    • Updated leaderboard filter test coverage to verify that selecting a club adds the expected value to the URL and that clearing filters removes it. This helps ensure the URL stays in sync with the visible filter state when users apply or clear club filters.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@tahminator
tahminator requested a review from a team November 21, 2026 17:53
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The leaderboard end-to-end test now checks the filters URL parameter for gwc after selecting a club and after clearing filters. The leaderboard visibility and response assertions remain unchanged.

Changes: Leaderboard filter URL assertion

Layer / File(s) Summary
URL filter assertions
e2e/src/leaderboard/filters.spec.ts
The test checks that filters includes gwc after club selection and excludes it after clearing filters. The leaderboard visibility and response assertions are unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: angelayu0530

Merge Risk: Minimal · up to 2064e

This change only updates an end-to-end test assertion to match the consolidated filters URL parameter. It has no production impact, and the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: it fixes the leaderboard filter E2E URL assertions. The raw summary confirms the club-filter test now checks the consolidated filters parameter containing gwc instead of gw…
Description check Passed The description follows the repository template. It explains the change: the club filter E2E test now validates the filters=gwc URL parameter instead of the legacy gwc=true parameter. The Description …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: it fixes the leaderboard filter E2E URL assertions. The raw summary confirms the club-filter test now checks the consolidated filters parameter containing gwc instead of gwc=true. The title is specific and matches the single change in the changeset.

Full details: Description check

Explanation

The description follows the repository template. It explains the change: the club filter E2E test now validates the filters=gwc URL parameter instead of the legacy gwc=true parameter. The Description of changes section and the Checklist are filled in, and the Screenshots section is addressed for Dev and Staging. Several checklist items remain unchecked: CI is not confirmed green, the AI comments are not marked resolved, and the dev QA is not done. The author explains why the E2E could not be rerun locally and why staging was not checked. Those gaps are explained, so the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1253d7e7-88a8-4964-8bbb-c489b1885ebd
Commits

Reviewing files that changed from the base of the PR and between b420ebc and 2064e89.

Files selected for processing: 1

  • e2e/src/leaderboard/filters.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

Available PR Commands

  • /migrate - Applies this PR's database migrations to the staging DB (can only be run by someone on @Patina-Network/codebloom)
  • /copy - Triggers copy from production to staging db (can only be run by tahminator or angelayu0530)
  • /e2e-test - Runs E2E tests on this PR's head commit (requires write access to the repo)

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-stealer-service/tags under the following tags:

  • codebloom-leetcode-auth-stealer-service:staging-latest
  • codebloom-leetcode-auth-stealer-service:staging-2026.11.21-12.53.23
  • codebloom-leetcode-auth-stealer-service:staging-ef35832

@tahminator

Copy link
Copy Markdown
Member Author

/e2e-test

@sonarqubecloud

Copy link
Copy Markdown

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-service-arm/tags under the following tags:

  • codebloom-leetcode-auth-service-arm:staging-latest
  • codebloom-leetcode-auth-service-arm:staging-2026.11.21-12.53.26
  • codebloom-leetcode-auth-service-arm:staging-ef35832

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-service/tags under the following tags:

  • codebloom-leetcode-auth-service:staging-latest
  • codebloom-leetcode-auth-service:staging-2026.11.21-12.53.23
  • codebloom-leetcode-auth-service:staging-ef35832

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom/tags under the following tags:

  • codebloom:staging-latest
  • codebloom:staging-2026.11.21-12.55.22
  • codebloom:staging-ef35832

@sonarqubecloud

Copy link
Copy Markdown

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-standup-bot-arm/tags under the following tags:

  • codebloom-standup-bot-arm:staging-latest
  • codebloom-standup-bot-arm:staging-2026.11.21-12.53.35
  • codebloom-standup-bot-arm:staging-ef35832

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-arm/tags under the following tags:

  • codebloom-arm:staging-latest
  • codebloom-arm:staging-2026.11.21-12.55.46
  • codebloom-arm:staging-ef35832

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-standup-bot/tags under the following tags:

  • codebloom-standup-bot:staging-latest
  • codebloom-standup-bot:staging-2026.11.21-12.53.23
  • codebloom-standup-bot:staging-ef35832

@pat-agent

pat-agent Bot commented Nov 21, 2026

Copy link
Copy Markdown

The image has been uploaded to https://hub.docker.com/r/patinanetwork/codebloom-leetcode-auth-stealer-service-arm/tags under the following tags:

  • codebloom-leetcode-auth-stealer-service-arm:staging-latest
  • codebloom-leetcode-auth-stealer-service-arm:staging-2026.11.21-12.53.33
  • codebloom-leetcode-auth-stealer-service-arm:staging-ef35832

@tahminator
tahminator enabled auto-merge (squash) November 21, 2026 18:07
@tahminator
tahminator merged commit d69334e into main Nov 21, 2026
33 checks passed
@tahminator
tahminator deleted the fix/e2e-leaderboard-filter-url branch November 21, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants