Repository navigation
Always use HTTPS for the Data API - #2
Merged
Merged
Conversation
Requests to any port other than 443 went out over plain HTTP, including the login request carrying Basic credentials. FileMaker Server serves the Data API only over HTTPS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while drafting the 1.0.0 release notes. For any port other than 443,
FileMakerServerandFMPSessionbuilthttp://URLs. On a server reached at, say,port: 8443, the login request sent itsAuthorization: Basicheader in cleartext, and every later request sent the bearer token the same way.FileMaker Server serves the Data API only over HTTPS, so the port-based scheme switch had no legitimate use. All four URL builders (database list, login, logout,
baseURL) now always usehttps://.Test: the new
Transportsuite records the URLs aFileMakerServeractually requests through a stubURLProtocol, on ports 443, 8443 and 80, for one unauthenticated call and one call that logs in. Every URL has to behttpson the configured port. The suite fails on the old code (ports 8443 and 80) and passes now.Verified: 17 tests pass on macOS (Xcode, warnings as errors) and on Linux with Swift 6.2 and 6.4 (
swift:*-noble, warnings as errors).I'm holding the DataAPI 1.0.0 tag until this merges, so 1.0.0 doesn't ship with the cleartext path. AdminAPI already uses HTTPS only, and AuthNet's endpoints are fixed HTTPS URLs.
🤖 Generated with Claude Code