Repository navigation
fix(client): register the bundle under the package name - #25
Closed
N-o-c-t-i-s wants to merge 1 commit into
Closed
N-o-c-t-i-s wants to merge 1 commit into
N-o-c-t-i-s wants to merge 1 commit into
Conversation
The host keys client graph rows by package name, so `id: "dsh-github"` left `@perrylink/dsh-github` unimportable and the host never mounted the client half. Derive the id from package.json, rebuild the artifact, and assert the registration id in the bundle test.
|
+1 — independently reproduced the same non-bootable desktop profile with 0.7.24 (environment and crash logs in #16; the Could this be merged and published as 0.7.25? npm still serves 0.7.24 as |
Owner
|
Thanks — this is the same contract as #24, which landed and shipped in 0.7.25 (the wrapper id now comes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shipped
lib/client.jsregisteredid: "dsh-github", but the host keys client graph rows by package name, so@perrylink/dsh-githubwas never imported — a desktop profile that installs the plugin fails to boot its client half. The bundler now derives the id frompackage.json, the artifact is rebuilt, andtest/client-bundle.test.tsasserts the registration id equals the package name (it fails against the old bundle).