Repository navigation
test(user): ensure secrets never appear in serialisation views - #340
Merged
Merged
Conversation
Assert password digests and SSO access / refresh tokens are absent from every public, admin, metadata and group view (JSON and struct), and that admin-only fields such as sys_admin stay out of the public views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression specs on the model side:
PUBLIC_DATA/ADMIN_DATAnever listpassword,password_digest,access_token,refresh_token,expires_atorexpiressys_admin,support,misc,login_name,card_number,ui_theme) are missing from the public views and present in the admin viewsTest plan
spec/user_spec.cr"sensitive field serialisation"🤖 Generated with Claude Code