Repository navigation
Warn when estimating percentage returns from non-positive prices - #779
Open
yugeshsarikonda wants to merge 1 commit into
Open
yugeshsarikonda wants to merge 1 commit into
yugeshsarikonda wants to merge 1 commit into
Conversation
Identify the affected asset and date without changing return calculations. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percentage-return estimates can be misleading when prices are zero or negative.
returns_from_pricesnow emits a UserWarning naming the first affected asset and date and suggesting absolute price changes for instruments that can trade at or below zero.Fixes #774. Existing return calculations remain unchanged, including the behavior already covered by the negative-price tests. Mean and EMA estimators inherit the warning through the shared helper. Already-computed returns passed with
returns_data=Trueare unaffected.Validation:
git diff --checkpassed.Implemented and tested with AI assistance from OpenAI Codex.