Repository navigation
Conversation
Make a writable copy before shuffling, matching inequality.md. Assisted-by: Codex (GPT-6)
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downloadable inequality data notebook still used a read-only NumPy view of a pandas Series, so
random.shufflefailed under pandas 3. Make a writable copy, matching the fix already ininequality.md.Addresses the notebook crash reported in #835.
I reproduced the failure on the original notebook, then ran the patched notebook end to end with the full SCF dataset: 509,455 rows, 20 years and all three income/wealth measures. All 60 Gini values matched an independent calculation within floating-point tolerance. Validation used Python 3.13.17, pandas 3.0.5, NumPy 2.5.2 and QuantEcon 0.13.1.
This fixes the crash only. The broader question of executing static notebooks in CI remains open; I did not run the full lecture-book build.
Assisted-by: Codex (GPT-6)