Repository navigation
[components][lwp] split syscall implementation by subsystem - #11894
Merged
Merged
Conversation
- move syscall implementations from lwp_syscall.c into syscall/ - group memory, file, socket, process, IPC and time syscalls - add a shared syscall dispatch table and internal header - register the new directory from the LWP build script - no functional change
BernardXiong
marked this pull request as ready for review
October 18, 2026 12:07
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
github-actions
Bot
added
RT-Smart
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_lwpReviewers: @xu18838022837 Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-10-18 21:41 CST)
📝 Review Instructions
|
- format the newly split syscall implementation files - no functional change
|
Comment on lines
+45
to
+57
| sysret_t sys_sigaction(int sig, const struct k_sigaction *act, | ||
| struct k_sigaction *oact, size_t sigsetsize) | ||
| { | ||
| int ret = -RT_EINVAL; | ||
| struct rt_lwp *lwp; | ||
| struct lwp_sigaction kact, *pkact = RT_NULL; | ||
| struct lwp_sigaction koact, *pkoact = RT_NULL; | ||
|
|
||
| if (!sigsetsize) | ||
| { | ||
| SET_ERRNO(EINVAL); | ||
| goto out; | ||
| } |
Contributor
Member
Author
There was a problem hiding this comment.
关系不大，哪个合并，另外一个可以rebase下即可。
rcitach
reviewed
Oct 28, 2026
Rbb666
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
为什么提交这份PR (why to submit this PR)
lwp_syscall.c contains more than eleven thousand lines covering memory, file system, socket, process, IPC and time syscalls. The single file is difficult to navigate and review.
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
This PR is a mechanical refactor. There is no functional change.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up