Repository navigation
make finalize() a no-op for never-constructed module objects - #1518
Open
kevinushey wants to merge 2 commits into
Open
kevinushey wants to merge 2 commits into
kevinushey wants to merge 2 commits into
Conversation
An object created without arguments for a class without a default constructor holds the dummy pointer, which is an environment rather than an external pointer. Its finalize() method passed it to CppObject__finalize, which failed, and the failure surfaced as "Expecting an external pointer: [type=environment]" during garbage collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A module object created without arguments for a class lacking a default constructor holds the dummy pointer set up in
.onLoad()(seecpp_object_dummy()), which is an environment rather than an external pointer. The generatedfinalize()method passed it toCppObject__finalize, which failed, and because the reference class registersfinalize()as the object's finalizer the failure surfaced at garbage collection:This makes
CppObject__finalizea no-op when handed the dummy pointer, using the same identity check againstrcpp_dummy_pointerthat theCppMethod__invoke*entry points already use (viaCHECK_DUMMY_OBJ), and adds a test. The test aborts with the error above on master.The check is on identity rather than on
TYPEOF(obj), so that a genuinely wrong.pointerstill errors instead of being silently ignored.Checklist
R CMD checkstill passes all testsChangeLogfile