Repository navigation
Conversation
Member
Author
|
There is probably a bit more work to be done on this but it is quite late for me and I spent far more time on this than I had thought haha. @michaelmess-de, please review the revised semantics and platform behaviour. Will come back to this over the weekend. |
michaelmess-de
suggested changes
Oct 24, 2026
steadytao
force-pushed
the
nice-process-priorities
branch
from
October 24, 2026 13:59
e89f2be to
5b1749b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1011 and the chain before it established proposal(s) and option-design discussion. This PR implements the feature in a bit of a cleaner manner after reviewing that work.
Summary
Adds
--niceand--no-niceto control CPU and I/O scheduling priorities for local and remote rsync processes.Settings can target the local process, remote process or both. CPU and I/O values compose independently and later settings replace only the component they specify. Unsupported or denied local changes produce a warning without terminating the transfer. Daemon clients cannot raise a worker above its inherited priorities.
rrsyncaccepts only local priority reductions. Local-only settings work with older peers while remote settings require peer support.