Skip to content

Refactoring random sample - #170

Merged
nikk-nikaznan merged 3 commits into
mainfrom
nkna/143-refactor
Nov 19, 2026
Merged

nikk-nikaznan merged 3 commits into
mainfrom
nkna/143-refactor

Conversation

@nikk-nikaznan

Copy link
Copy Markdown
Collaborator

@nikk-nikaznan nikk-nikaznan changed the title Nkna/143 refactor Refactoring random sample Nov 12, 2026

@yhong123 yhong123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just need @tim-band to give it a quick double-check.

@tim-band tim-band left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@nikk-nikaznan
nikk-nikaznan merged commit 539800a into main Nov 19, 2026
2 checks passed
@nikk-nikaznan
nikk-nikaznan deleted the nkna/143-refactor branch November 19, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract ORDER BY RANDOM() ... LIMIT into a dialects.py random_sample() helper

3 participants